Open
Conversation
This change adds a region field for Network Domains as multiple resources look for VPCs using Network Domain Listing and then they need to check what is the region associated with them. Apart from the performance (sending additional requests to check the already known region) there is a risk of using invalid Network Domain if there are multiple VPCs with the same ID in different regions.
saswatp
requested changes
May 15, 2024
Member
saswatp
left a comment
saswatp
left a comment
There was a problem hiding this comment.
Let's not change network domain proto. This will create regression that can't be fully tested with our existing tests. If AWS / GCP connectivity doesn't need region we should be able to connect Azure VPCs without need of a region.
| string accountId = 5; | ||
| string sideId = 6; | ||
| map<string, string> labels = 7; | ||
| string region = 8; |
Member
There was a problem hiding this comment.
Replace SideId (typo of siteId) with region and update other repos with this new info.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a region field for Network Domains as multiple resources look for VPCs using Network Domain Listing and then they need to check what is the region associated with them.
Apart from the performance (sending additional requests to check the already known region) there is a risk of using invalid Network Domain if there are multiple VPCs with the same ID in different regions.