Fix: Correct argument order for workflow import subject and description templates#2
Open
ashu82492 wants to merge 1 commit intoappform-io:masterfrom
Open
Fix: Correct argument order for workflow import subject and description templates#2ashu82492 wants to merge 1 commit intoappform-io:masterfrom
ashu82492 wants to merge 1 commit intoappform-io:masterfrom
Conversation
ashu82492
commented
Feb 6, 2026
| transition.getRule(), | ||
| transition.getActionIds()))); | ||
| return inWorkflow; | ||
| return workflow; |
Author
There was a problem hiding this comment.
Please double verify if this is correct.
This should return the the updated workflow rather than input inWorkflow.
Contributor
There was a problem hiding this comment.
ImportResult should be newly imported workflow, but here workflow might be incomplete as the Dto workflow object might not have complete transition and states,
Please re-read the workflow for import result, example schema
.flatMap(schemaSummary -> schemaStore.read(schemaSummary.getId()))
.map(schema -> new ImportResult<>(schema, true, null))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When importing workflows, the
subjectIdTemplateanddescriptionTemplatearguments were being passed in the wrong order to the workflow builder, causing these templates to be swapped during the import process.Changes Made
Fixed argument order in
WorkflowManager.javadescriptionTemplateandsubjectIdTemplateparametersFixed return value in import logic [Please review if this is correct]
workflowobject instead ofinWorkflowRemoved unused import
com.google.common.collect.SetsimportAdded test assertions
Updated test fixture
descriptionTemplateandsubjectIdTemplatefields toworkflow_details.jsonfixture to properly test the scenarioTesting
All existing tests pass and tested the import feature locally.