refactor: remove legacy fallback in toggle_location_services#1224
Merged
KazuCocoa merged 1 commit intoappium:masterfrom May 3, 2026
Merged
Conversation
Removed the deprecated fallback logic in `toggle_location_services` that used the `TOGGLE_LOCATION_SERVICES` command. The method now exclusively uses the `mobile: toggleGps` script. Also removed the `TOGGLE_LOCATION_SERVICES` constant from `MobileCommand` and its registration in `Location._add_commands`, as it is no longer used. Updated `test/unit/webdriver/device/location_test.py` to verify the new behavior.
KazuCocoa
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the deprecated fallback logic in
toggle_location_servicesthat used theTOGGLE_LOCATION_SERVICEScommand. The method now exclusively uses themobile: toggleGpsscript.Also removed the
TOGGLE_LOCATION_SERVICESconstant fromMobileCommandand its registration inLocation._add_commands, as it is no longer used.Updated
test/unit/webdriver/device/location_test.pyto verify the new behavior.