Skip to content

Show plugin settings in system property list#1696

Open
amarkdotdev wants to merge 1 commit into
apple:mainfrom
amarkdotdev:codex/plugin-property-list
Open

Show plugin settings in system property list#1696
amarkdotdev wants to merge 1 commit into
apple:mainfrom
amarkdotdev:codex/plugin-property-list

Conversation

@amarkdotdev

@amarkdotdev amarkdotdev commented Jun 11, 2026

Copy link
Copy Markdown

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Motivation and Context

container system property list showed core system configuration but omitted plugin-scoped values from [plugin.*] sections. This change includes those plugin settings in TOML and JSON output, using the same daemon-reported app-root and install-root config files as the core system properties. Nested plugin values preserve the existing first-match-wins layering behavior.

Fixes #607

Testing

  • Tested locally
  • Added/updated tests
  • Added/updated docs

Commands run locally:

  • swift test --filter PluginPropertiesTests
  • swift test --filter ContainerCommandsTests

@amarkdotdev amarkdotdev force-pushed the codex/plugin-property-list branch 3 times, most recently from 97167bb to 4cfca1e Compare June 15, 2026 15:21
@jglogan jglogan requested a review from katiewasnothere June 15, 2026 17:22
@amarkdotdev amarkdotdev force-pushed the codex/plugin-property-list branch from 4cfca1e to b67d8b0 Compare June 16, 2026 05:42
@amarkdotdev

Copy link
Copy Markdown
Author

Gentle ping on this one (open since June 11). It implements #607container system property list now includes [plugin.*] settings in both TOML and JSON output, sourced from the same daemon-reported app-root and install-root config files as the core system properties, with the existing first-match-wins layering preserved.

It's self-contained (a new PluginProperties loader + PluginPropertyValue model, wired into PropertyList) and covered by tests for rendering, all TOML value types including nested tables, and precedence/override behavior (swift test --filter PluginPropertiesTests passes locally). The container project - PR build workflow is in the "action required" state pending a maintainer's approval to run. Could a maintainer approve the run and take a look? Happy to adjust anything. Fixes #607.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: container system property ls includes plugin settings values.

2 participants