You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
container system property list showed core system configuration but omitted plugin-scoped values from [plugin.*] sections. This change includes those plugin settings in TOML and JSON output, using the same daemon-reported app-root and install-root config files as the core system properties. Nested plugin values preserve the existing first-match-wins layering behavior.
Gentle ping on this one (open since June 11). It implements #607 — container system property list now includes [plugin.*] settings in both TOML and JSON output, sourced from the same daemon-reported app-root and install-root config files as the core system properties, with the existing first-match-wins layering preserved.
It's self-contained (a new PluginProperties loader + PluginPropertyValue model, wired into PropertyList) and covered by tests for rendering, all TOML value types including nested tables, and precedence/override behavior (swift test --filter PluginPropertiesTests passes locally). The container project - PR build workflow is in the "action required" state pending a maintainer's approval to run. Could a maintainer approve the run and take a look? Happy to adjust anything. Fixes #607.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
container system property listshowed core system configuration but omitted plugin-scoped values from[plugin.*]sections. This change includes those plugin settings in TOML and JSON output, using the same daemon-reported app-root and install-root config files as the core system properties. Nested plugin values preserve the existing first-match-wins layering behavior.Fixes #607
Testing
Commands run locally:
swift test --filter PluginPropertiesTestsswift test --filter ContainerCommandsTests