Skip to content

Fix: race conditions in DefaultNetworkService.lookup by removing async from AttachmentAllocator.lookup #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GarySkywalker-droid wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −2
Open

Fix: race conditions in DefaultNetworkService.lookup by removing async from AttachmentAllocator.lookup #1699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ec4c1f
fix: removed the async from AttachmentAllocator.lookup, causing the r…
GarySkywalker-droid Jun 11, 2026
0be4574
Merge branch 'apple:main' into fix/dns-racing-condition
GarySkywalker-droid Jun 11, 2026
cb2da9a
fix: had removed the slash by mistake
GarySkywalker-droid Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Services/Network/Server/AttachmentAllocator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ actor AttachmentAllocator {
}

/// Retrieve the allocator index for a hostname.
func lookup(hostname: String) async throws -> UInt32? {
func lookup(hostname: String) throws -> UInt32? {
hostnames[hostname]
}
}
2 changes: 1 addition & 1 deletion Sources/Services/Network/Server/DefaultNetworkService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public actor DefaultNetworkService: NetworkService {
}

// Invariant: hostname -> index if and only if index -> MAC address
let index = try await allocator.lookup(hostname: hostname)
let index = try allocator.lookup(hostname: hostname)
guard let index else {
return nil
}
Expand Down