Fix duplicate "(default: 3)" in --max-concurrent-downloads help text#1725
Merged
katiewasnothere merged 1 commit intoJun 16, 2026
Merged
Conversation
Remove manually specified default value from help string since ArgumentParser already appends it automatically from the property's default value. Signed-off-by: Charlie Le <charlie_le@apple.com>
CharlieTLe
force-pushed
the
fix-duplicate-default-in-help
branch
from
fe6ebd0 to
ac2ed21
Compare
dcantah
approved these changes
Jun 15, 2026
jglogan
approved these changes
Jun 15, 2026
Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove manually specified default value from help string since ArgumentParser already appends it automatically from the property's default value.
Type of Change
Motivation and Context
Running
container machine create -hdisplays "(default: 3)" twice for the--max-concurrent-downloadsoption. This is because the help string manually includes "(default: 3)" while ArgumentParser also automatically appends the default value from the property initializer.Testing