add ID validation to daemon service#1735
Open
0xf00sec wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI validates container IDs via Utility.validEntityName before sending XPC requests, but the daemon never checked the ID itself. Any process talking directly to com.apple.container.apiserver could pass a path-traversal string (../../tmp/foo) as a container ID, causing the daemon to create, measure, or export bundles outside of containerRoot.
I've Added Utility.validEntityName checks in ContainersService at the entry point of create, containerDiskUsage, and exportRootfs -- the three functions that build filesystem paths from the container ID. The daemon now enforces the same naming rules as the CLI regardless of how the XPC service is reached.