Add a new Socket Stream Protocol - #47
Merged
Merged
Conversation
PayasR
changed the title
PayasR
force-pushed
the
payasr/SocketProtocol
branch
2 times, most recently
from
July 13, 2026 18:53
1d6247e to
27f4de0
Compare
agnosticdev
reviewed
Jul 13, 2026
agnosticdev
left a comment
agnosticdev
left a comment
Collaborator
There was a problem hiding this comment.
A few things, mainly on creating test harness code.
agnosticdev
reviewed
Aug 7, 2026
agnosticdev
left a comment
agnosticdev
left a comment
Collaborator
There was a problem hiding this comment.
Everything looks good, it just looks like there are some linux test failures outstanding.
| let harness = UDPLoopbackHarness(basePort: 10840) | ||
| harness.start() | ||
| harness.expectDeliver([0xFF]) | ||
| harness.teardown() |
Collaborator
There was a problem hiding this comment.
Yep, this is exactly what we want, thanks!
PayasR
force-pushed
the
payasr/SocketProtocol
branch
from
August 7, 2026 17:02
f9d3b02 to
471a92d
Compare
PayasR
force-pushed
the
payasr/SocketProtocol
branch
12 times, most recently
from
August 10, 2026 18:42
8245a76 to
adf0813
Compare
PayasR
force-pushed
the
payasr/SocketProtocol
branch
from
August 10, 2026 19:40
adf0813 to
f7e3928
Compare
The read DispatchSource was armed in setup(), before connect completed. On Linux a spurious readable edge at connect-completion left it permanently silent, stalling all receives. Resume the read source only after connect completes. Also consolidate the read and write sources onto one shared dup'd fd (closed via a refcount once both cancel) to avoid epoll fd-aliasing and the EPOLLFREE abort that fires when a still-registered socket fd is closed. Applied to both SocketStreamProtocol and SocketDatagramProtocol.
PayasR
force-pushed
the
payasr/SocketProtocol
branch
from
August 10, 2026 20:18
6b8ec6c to
66157a7
Compare
agnosticdev
approved these changes
Aug 10, 2026
agnosticdev
left a comment
agnosticdev
left a comment
Collaborator
There was a problem hiding this comment.
Great, thank you very much @PayasR !
holleman
approved these changes
Aug 10, 2026
| guard let reference = TCPProtocol().newProtocolInstance(context: context) else { | ||
| throw NetworkError.posix(EINVAL) | ||
| if case .custom(let linkOptions) = stack.link, | ||
| linkOptions.identifier == BridgeDatagramProtocol.identifier |
There was a problem hiding this comment.
A little unusual to be using the BridgeDatagramProtocol for TCP
| } else { | ||
| let socketReference = SocketStreamProtocol.instance(context: context) | ||
| options.setProtocolInstance(socketReference) | ||
| let linkage = OutboundStreamLinkage(reference: socketReference) |
There was a problem hiding this comment.
a lot of this is repeated - it's really about setting the instance and getting the linkage and the rest is the same.
|
|
||
| @_spi(ProtocolProvider) | ||
| @available(Network 0.1.0, *) | ||
| public func parseIPv4(_ string: String) -> IPv4Address? { |
There was a problem hiding this comment.
these can be replaced now that https://github.com/apple/swift-network-evolution/pull/44/changes went in
tfpauly
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets us use Kernel TCP socket streams for when userspace TCP isn't available.