fix: map action inputs to drone-ssh environment names - #414
Open
MikeeI wants to merge 1 commit into
Open
Conversation
The composite adapter exported three names that pinned drone-ssh v1.8.2 does not consume and omitted proxy protocol entirely. Use INPUT_ALLENVS, INPUT_CIPHERS, INPUT_PROXY_CIPHERS, and INPUT_PROXY_PROTOCOL while preserving every public action input name and value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The composite adapter exports three public inputs under environment names that pinned
drone-ssh v1.8.2does not consume and omitsproxy_protocolentirely.This change maps the four existing public inputs to the binary's recognized names without changing the action interface.
Evidence
action.ymlon the current base exportsINPUT_ALL_ENVS,INPUT_CIPHER, andINPUT_PROXY_CIPHERand has noINPUT_PROXY_PROTOCOL.drone-ssh v1.8.2consumesINPUT_CIPHERS.INPUT_PROXY_PROTOCOL,INPUT_PROXY_CIPHERS, andINPUT_ALLENVS.Changes
allenvstoINPUT_ALLENVS.cipherandproxy_ciphertoINPUT_CIPHERSandINPUT_PROXY_CIPHERS.proxy_protocoltoINPUT_PROXY_PROTOCOL.Risks and boundaries
drone-ssh v1.8.2; explicit custom version overrides remain outside this compatibility claim.envsforwarding remains unchanged.Verification
yq v4.53.3parsedaction.ymland confirmed all four public declarations and exact recognized mappings.INPUT_ALL_ENVS,INPUT_CIPHER, andINPUT_PROXY_CIPHERare no longer injected.git diff --check— passed.I checked the relevant issues, comments, pull requests, discussions, releases, and both repositories' naming history; this pull request is not a duplicate.
Disclosure
Investigated thoroughly with GPT-5.6 Codex (high reasoning effort), using Oh My Pi as the agent framework.
This report is not generic or unreviewed AI-generated output. Its claims were checked against the cited evidence, and it includes the relevant detail intended to help maintainers resolve the issue.
If reports like this are not useful to the project, please let me know and I will refrain from submitting similar ones. My intent is to help without wasting maintainer time or energy or discouraging their work.
Thank you for your work.