Skip to content

fix: map action inputs to drone-ssh environment names - #414

Open
MikeeI wants to merge 1 commit into
appleboy:masterfrom
MikeeI:fix/input-env-mappings
Open

fix: map action inputs to drone-ssh environment names#414
MikeeI wants to merge 1 commit into
appleboy:masterfrom
MikeeI:fix/input-env-mappings

Conversation

@MikeeI

@MikeeI MikeeI commented Aug 10, 2026

Copy link
Copy Markdown

Summary

The composite adapter exports three public inputs under environment names that pinned drone-ssh v1.8.2 does not consume and omits proxy_protocol entirely.
This change maps the four existing public inputs to the binary's recognized names without changing the action interface.

Evidence

Changes

  • Map allenvs to INPUT_ALLENVS.
  • Map cipher and proxy_cipher to INPUT_CIPHERS and INPUT_PROXY_CIPHERS.
  • Map proxy_protocol to INPUT_PROXY_PROTOCOL.
  • Preserve every public input name, value, default, and binary-owned validation path.

Risks and boundaries

  • The mappings are proven against the action's default drone-ssh v1.8.2; explicit custom version overrides remain outside this compatibility claim.
  • No compatibility aliases, action-side validation, documentation changes, or generated mapping layer are added.
  • Existing envs forwarding remains unchanged.

Verification

  • yq v4.53.3 parsed action.yml and confirmed all four public declarations and exact recognized mappings.
  • Assertions confirmed that INPUT_ALL_ENVS, INPUT_CIPHER, and INPUT_PROXY_CIPHER are no longer injected.
  • git diff --check — passed.

I checked the relevant issues, comments, pull requests, discussions, releases, and both repositories' naming history; this pull request is not a duplicate.

Disclosure

Investigated thoroughly with GPT-5.6 Codex (high reasoning effort), using Oh My Pi as the agent framework.

This report is not generic or unreviewed AI-generated output. Its claims were checked against the cited evidence, and it includes the relevant detail intended to help maintainers resolve the issue.

If reports like this are not useful to the project, please let me know and I will refrain from submitting similar ones. My intent is to help without wasting maintainer time or energy or discouraging their work.

Thank you for your work.

The composite adapter exported three names that pinned drone-ssh v1.8.2 does not consume and omitted proxy protocol entirely.

Use INPUT_ALLENVS, INPUT_CIPHERS, INPUT_PROXY_CIPHERS, and INPUT_PROXY_PROTOCOL while preserving every public action input name and value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant