Skip to content

fix: corrected misleading storeValue logic in JS best practices #2977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YasasBanuka wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −8
Open

fix: corrected misleading storeValue logic in JS best practices #2977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions website/docs/write-code/best-practices.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,16 @@ In this example, the third parameter `persist` in the [storeValue()](/reference/

```jsx
export default {
fetch_name () {
storeValue('name', 'sam', true);
return appsmith.store.name;
},
update_name () {
storeValue('name', 'ben', true);
return appsmith.store.name;
},
// Pure getter: returns the name, or 'sam' if it's not set yet
fetch_name () {
return appsmith.store.name || 'sam';
},

// Setter: correctly forces the name to change to 'ben'
update_name () {
storeValue('name', 'ben', true);
return appsmith.store.name;
},
}
```
You can then refer to the stored computed value in widgets.
Expand Down