Skip to content

Feat : move GitHub button above #2580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ItzNotABug merged 7 commits into from
Dec 31, 2025
Merged

Feat : move GitHub button above #2580

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c7cd36f
feaT: move github button above email-pass signup and signin
HarshMN2345 Oct 30, 2025
625abac
added space below gitbutton
HarshMN2345 Nov 10, 2025
c1ccca5
enable sign up with github button even if not checked
HarshMN2345 Dec 22, 2025
26f7431
onGithubLogin() to check for code or campaign parameters
HarshMN2345 Dec 29, 2025
8c514b7
addressed a comment
HarshMN2345 Dec 29, 2025
a0a9987
inline styles
HarshMN2345 Dec 29, 2025
0a8d7ee
use :style
HarshMN2345 Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions src/routes/(public)/(guest)/login/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,18 @@
<svelte:fragment>
<Form onSubmit={login}>
<Layout.Stack>
{#if isCloud}
<Button
class="auth-provider-button"
secondary
fullWidth
on:click={onGithubLogin}
{disabled}>
<span class="icon-github" aria-hidden="true"></span>
<span class="text">Sign in with GitHub</span>
</Button>
<span class="with-separators eyebrow-heading-3">or</span>
{/if}
<InputEmail
id="email"
label="Email"
Expand All @@ -108,13 +120,6 @@
required={true}
bind:value={pass} />
<Button fullWidth submit {disabled}>Sign in</Button>
{#if isCloud}
<span class="with-separators eyebrow-heading-3">or</span>
<Button secondary fullWidth on:click={onGithubLogin} {disabled}>
<span class="icon-github" aria-hidden="true"></span>
<span class="text">Sign in with GitHub</span>
</Button>
{/if}
</Layout.Stack>
</Form>
</svelte:fragment>
Expand All @@ -129,3 +134,9 @@
</li>
</svelte:fragment>
</Unauthenticated>

<style>
:global(.auth-provider-button) {
margin-bottom: var(--gap-s, 8px);
}
Copy link
Member

@ItzNotABug ItzNotABug Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe lets just wrap the button for now in a div with this style. don't wanna add more globals. we anyway plan to remove class support from Pink because it makes us use :global. Same for the other one.

</style>
31 changes: 19 additions & 12 deletions src/routes/(public)/(guest)/register/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,19 @@
<svelte:fragment>
<Form onSubmit={register}>
<Layout.Stack>
{#if isCloud}
<Button
class="auth-provider-button"
secondary
fullWidth
on:click={onGithubLogin}
{disabled}>
<span class="icon-github" aria-hidden="true"></span>
<span class="text">Sign up with GitHub</span>
</Button>
<span class="with-separators eyebrow-heading-3">or</span>
{/if}

<InputText
id="name"
label="Name"
Expand Down Expand Up @@ -159,18 +172,6 @@
>.</InputChoice>

<Button fullWidth submit disabled={disabled || !terms}>Sign up</Button>

{#if isCloud}
<span class="with-separators eyebrow-heading-3">or</span>
<Button
secondary
fullWidth
on:click={onGithubLogin}
disabled={disabled || !terms}>
<span class="icon-github" aria-hidden="true"></span>
<span class="text">Sign up with GitHub</span>
</Button>
{/if}
</Layout.Stack>
</Form>
</svelte:fragment>
Expand All @@ -181,3 +182,9 @@
</Typography.Text>
</svelte:fragment>
</Unauthenticated>

<style>
:global(.auth-provider-button) {
margin-bottom: var(--gap-s, 8px);
}
</style>