-
Notifications
You must be signed in to change notification settings - Fork 205
fix: pass platform key to wizard when continuing platform setup #2739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pass platform key to wizard when continuing platform setup #2739
Conversation
Fixes #10873 - Cannot read properties of undefined (reading 'smallIcon') When clicking 'Continue' on an existing web platform, the wizard was not receiving the framework key, causing selectedFramework to be undefined.
Console (appwrite/console)Project ID: Sites (1)
Tip GraphQL API works alongside REST and WebSocket protocols |
WalkthroughThe pull request adds a new optional Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🧰 Additional context used📓 Path-based instructions (5)**/*.{ts,tsx,js,jsx,svelte}📄 CodeRabbit inference engine (AGENTS.md)
Files:
src/routes/**/*.svelte📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{ts,tsx,js,jsx,svelte,json}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.svelte📄 CodeRabbit inference engine (AGENTS.md)
Files:
src/routes/**📄 CodeRabbit inference engine (AGENTS.md)
Files:
🧠 Learnings (2)📚 Learning: 2025-11-19T11:22:42.553ZApplied to files:
📚 Learning: 2025-11-19T11:22:42.553ZApplied to files:
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |

Fixes #10873 - Cannot read properties of undefined (reading 'smallIcon')
When clicking 'Continue' on an existing web platform, the wizard was not receiving the framework key, causing selectedFramework to be undefined.
What does this PR do?
Fixes the crash that occurs when clicking "Continue" on an existing web platform in the onboarding flow.
Root Cause: The
continuePlatform()function was not passing the frameworkkeyto the wizard, causingselectedFrameworkto beundefined.Changes:
keyparameter tocontinuePlatform()platform.keywhen calling the functionTest Plan
Ran
pnpm run check(0 errors) andpnpm run lint(passed).Related PRs and Issues
Fixes appwrite/appwrite#10873
Have you read the Contributing Guidelines on issues?
Yes
Summary by CodeRabbit
Bug Fixes
Refactor
✏️ Tip: You can customize this high-level summary in your review settings.