Skip to content

fix: prevent Safari Smart Quotes from corrupting JSON in execution body (#11021) #2742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
suhaniawasthi10 wants to merge 2 commits into from
Closed

fix: prevent Safari Smart Quotes from corrupting JSON in execution body (#11021) #2742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67121a1
fix: pass platform key to wizard when continuing platform setup
suhaniawasthi10 Dec 25, 2025
3b75d4a
fix: add spellcheck=false to execution body textarea to prevent Safar…
suhaniawasthi10 Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...[region]-[project]/functions/function-[function]/executions/execute-function/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@
<InputTextarea
placeholder="Enter request body here..."
id="body"
spellcheck={false}
bind:value={body} />
</Layout.Stack>
</Accordion>
Expand Down Expand Up @@ -292,6 +293,7 @@
<InputTextarea
placeholder="Enter request body here..."
id="body"
spellcheck={false}
bind:value={body} />
</Layout.Stack>
</Accordion>
Expand Down
2 changes: 1 addition & 1 deletion src/routes/(console)/project-[region]-[project]/overview/onboard.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@

function openPlatformWizard(type: number, platform?: Models.Platform) {
if (platform) {
continuePlatform(type, platform.name, platform.type);
continuePlatform(type, platform.name, platform.type, platform.key);
} else {
trackEvent(Click.PlatformCreateClick, { source: 'onboarding' });
addPlatform(type);
Expand Down
10 changes: 8 additions & 2 deletions src/routes/(console)/project-[region]-[project]/overview/platforms/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@
});
}

export async function continuePlatform(platform: Platform, name: string, type: PlatformType) {
export async function continuePlatform(
platform: Platform,
name: string,
type: PlatformType,
key?: string
) {
createPlatform.set({
name: name,
type: type
Expand All @@ -40,7 +45,8 @@

wizard.start(platforms[platform], null, 1, {
isConnectPlatform: true,
platform: type
platform: type,
key: key
});
}

Expand Down
2 changes: 1 addition & 1 deletion src/routes/(console)/project-[region]-[project]/overview/platforms/createWeb.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ APPWRITE_ENDPOINT = "${sdk.forProject(page.params.region, page.params.project).c
{/if}
</Layout.Stack>
</Form>
{:else}
{:else if selectedFramework}
<Card.Base padding="s"
><Layout.Stack direction="row" justifyContent="space-between" alignItems="center">
<Layout.Stack gap="xxs" direction="row">
Expand Down