Skip to content

Modify GetComponent signatures to take const AActor* so they can be called from a const context #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
northstarswap wants to merge 1 commit into from
Closed

Modify GetComponent signatures to take const AActor* so they can be called from a const context #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Source/BlueprintComponentReference/BlueprintComponentReference.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ FString FBlueprintComponentReference::ToString() const
return Result.ToString();
}

UActorComponent* FBlueprintComponentReference::GetComponent(AActor* SearchActor) const
UActorComponent* FBlueprintComponentReference::GetComponent(const AActor* SearchActor) const
{
UActorComponent* Result = nullptr;

Expand All @@ -90,7 +90,8 @@ UActorComponent* FBlueprintComponentReference::GetComponent(AActor* SearchActor)
break;
case EBlueprintComponentReferenceMode::Path:
// Variation 2: subobject path
Result = FindObjectFast<UActorComponent>(SearchActor, Value);
// const-cast is used as FindObjectFast does not provide a signature with const AActor*
Result = FindObjectFast<UActorComponent>(const_cast<AActor*>SearchActor, Value);
break;
//case EBlueprintComponentReferenceMode::Dynamic:
// Variation 3: dynamic selection
Expand Down
4 changes: 2 additions & 2 deletions Source/BlueprintComponentReference/BlueprintComponentReference.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,15 +154,15 @@ struct BLUEPRINTCOMPONENTREFERENCE_API FBlueprintComponentReference
*
* @param SearchActor Actor to perform search in
*/
UActorComponent* GetComponent(AActor* SearchActor) const;
UActorComponent* GetComponent(const AActor* SearchActor) const;

/**
* Get the actual component pointer from this reference
*
* @param SearchActor Actor to perform search in
*/
template<typename T>
T* GetComponent(AActor* SearchActor) const
T* GetComponent(const AActor* SearchActor) const
{
return Cast<T>(GetComponent(SearchActor));
}
Expand Down