Fix types for react native 0.72 and more

[MateuszRostkowski]

Issue:
React native in 0.72 have added new type DimensionValue and react-native-whirlwind types are not working with react-native versions higher than 0.72.

React native changes:

• change introduced by react native
• change log

FYI:

• I have not tested this in projects with react-native versions lower than 0.72
• I have tested it on 0.72.1 and it works perfectly

In case someone want to test it, you can add my repository to your repo:

• https://stackoverflow.com/questions/43411864/how-to-install-package-from-github-repo-in-yarn
• https://github.com/MateuszRostkowski/react-native-whirlwind

[arabold]

Thank you for pointing this out and for your contribution 🙏. Unfortunately, this change isn't going to work ultimately. Everything in the dist/ folder is automatically generated when releasing a new package version. The types are originally defined in src/theme/ThemeProps.ts.

To make this work with 0.72, I believe there we need to change the types from string to DimensionValue. This would ensure we're using the same types as React does. I'm currently not working on any React Native projects professionally or personally and going to travel for the next two weeks, but I see if I can set up a local environment and test this properly.

If you urgently need a working version in the meantime, you can also check out patch-package which allows you to apply your own fixes (like this one) to NPM packages during installation.

[MateuszRostkowski]

@arabold
Thanks for response. Every change that I've made in dist folder was automatically, I've just run the npm script build.

To make this work I've done this steps:

1. Install new version of react native types - npm install --save @types/react-native@latest
2. Make change in src/styles/sizing.ts file because this hScreen: { height: '100vh' } is not working with new react native types
3. Build library: npm run build

For now I don't need to make the patch of this package, because I'm just using the fork in my app. So take your time and check this when you will be available.

[MateuszRostkowski]

@arabold
If it's needed I can remove all the changes that I've made in dist folder.