Open
Conversation
xelxebar
force-pushed
the
master
branch
4 times, most recently
from
10c4c7e to
424425d
Compare
xelxebar
changed the title
xelxebar
changed the title
Marks are reified as underscore-prefixed variables. Note that marks are saved per-document, so switching between buffers with `e` will replace mark variables with ones for new document.
Owner
|
Note sure how I feel about this one. I'll have to do some thinking about the design. I agree that the marks situation needs to be improved, but I wonder what the best way to do this is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marks are reified as underscore-prefixed variables due to their better affordances than direct strings, i.e. we can perform direct arithmetic on mark variables etc. Note, also, that updates to the document will auto-update variables as necessary. Moreover, marks are document-specific, so switching between documents with
ewill load and unload mark variables for you.Note: Needs integration with undo.
The above behavior hasn't been sanity-checked against
ed, however. Thoughts?