This repository was archived by the owner on Sep 17, 2021. It is now read-only.
Open
Conversation
This is a proposed redesign that may be a bit more natural to work
with from the Julia perspective. The principal difference are:
- Support eltypes of the form `SVector{T,N}`: this makes this wrapper
behave more like OpenCV itself, which (unlike Python) does not use
an array dimension to encode the number of color channels.
- Support `N0f8` and `N0f16`, JuliaImages preferred interpretation of
8- and 16-bit unsigned intensity data. (See FixedPointNumbers and
https://juliaimages.org/latest/tutorials/arrays_colors/#fixedpoint;
interestingly, OpenCV itself suffers from the exact same problem, see
https://stackoverflow.com/questions/14539498/change-type-of-mat-object-from-cv-32f-to-cv-8u
for an example of a user who got bit by the "divide by 255" rule.)
- Work towards support for multidimensional arrays (see
JuliaImages/OpenCV.jl#4)
- Validate arguments more carefully and improve correctness in a few
key places
Contributor
Author
Contributor
Author
|
Note that I didn't put colorspace into the |
Owner
|
Hi Tim, I should probably have archived this repository and will do that rn to avoid confusion. The changes that you made should go into https://github.com/opencv/opencv_contrib/tree/master/modules/julia/gen/jl_cxx_files instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposed redesign that may be a bit more natural to work
with from the Julia perspective. The principal differences are:
Support eltypes of the form
SVector{T,N}: this makes this wrapperbehave more like OpenCV itself, which (unlike Python) does not use
an array dimension to encode the number of color channels.
Support
N0f8andN0f16, JuliaImages preferred interpretation of8- and 16-bit unsigned intensity data. (See FixedPointNumbers and
https://juliaimages.org/latest/tutorials/arrays_colors/#fixedpoint;
interestingly, OpenCV itself suffers from the exact same problem, see
https://stackoverflow.com/questions/14539498/change-type-of-mat-object-from-cv-32f-to-cv-8u
for an example of a user who got bit by the "divide by 255" rule.)
Work towards support for multidimensional arrays (see
Multidimensional images JuliaImages/OpenCV.jl#4)
Validate arguments more carefully and improve correctness in a few
key places
Improve inferrability (avoid abstract types JuliaImages/OpenCV.jl#1)
This has not been tested (I don't know how, see JuliaImages/OpenCV.jl#3), so don't merge this unquestioningly.