Fix Plymouth theme preset focus and add missing strings to base.pot#4586
Open
Softer wants to merge 1 commit into
Open
Fix Plymouth theme preset focus and add missing strings to base.pot#4586Softer wants to merge 1 commit into
Softer wants to merge 1 commit into
Conversation
select_plymouth_theme() compared enum item values against a raw string, so the previously selected theme was never highlighted when reopening the menu. Use set_focus_by_value() like other single-select menus. Regenerate base.pot to pick up the three Plymouth strings introduced in archlinux#4555.
Torxed
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small follow-ups to #4555:
select_plymouth_theme()passedpreset.value(a string) toset_selected_by_value(), while the menu items holdPlymouthThemeenum values - so the previously selected theme was never highlighted when reopening the menu. Switched toset_focus_by_value(preset), matchingselect_bootloader()and the other single-select menus.base.potto pick up the three Plymouth strings ("Plymouth", "Select Plymouth theme", "Plymouth "{}"").