-
Notifications
You must be signed in to change notification settings - Fork 13
Add CI workflow to check that sketches compile #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
61a4add to
0758765
Compare
per1234
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use the GitHub Actions action we created specifically for this purpose?:
|
@per1234 has a valid point, but I would also consider compiling the sketch with profiles in order to be sure the list of libraries in the examples is correct, and there isn't any one missing. |
That should work fine using the arduino/compile-sketches action. It uses the latest release version of Arduino CLI by default (configurable), so all the capabilities of Arduino CLI are available. |
c5049be to
e1ce828
Compare
I didn't know about it. |
Since in each sketch folder there is a sketch.yaml with platform and profile specified, is it necessary to specify them in the compile-sketches step config? |
I would just specify the fqbn, i.e., |
Okay, I did it. |
c7be1c3 to
e4605ff
Compare
b07ab0e to
f5680a6
Compare
This reverts commit f5680a6.
This PR wants to avoid breaking examples, with a sketch, when dependencies change.