Skip to content

Conversation

@stefanotorneo
Copy link
Contributor

@stefanotorneo stefanotorneo commented Dec 15, 2025

This PR wants to avoid breaking examples, with a sketch, when dependencies change.

@stefanotorneo stefanotorneo force-pushed the stefanotorneo/check-sketches-deps branch from 61a4add to 0758765 Compare December 15, 2025 13:50
@stefanotorneo stefanotorneo marked this pull request as ready for review December 15, 2025 13:53
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the GitHub Actions action we created specifically for this purpose?:

https://github.com/arduino/compile-sketches

@lucarin91
Copy link
Contributor

@per1234 has a valid point, but I would also consider compiling the sketch with profiles in order to be sure the list of libraries in the examples is correct, and there isn't any one missing.

@per1234
Copy link
Contributor

per1234 commented Dec 16, 2025

but I would also consider compiling the sketch with profiles

That should work fine using the arduino/compile-sketches action. It uses the latest release version of Arduino CLI by default (configurable), so all the capabilities of Arduino CLI are available.

@stefanotorneo stefanotorneo force-pushed the stefanotorneo/check-sketches-deps branch from c5049be to e1ce828 Compare December 17, 2025 15:40
@stefanotorneo
Copy link
Contributor Author

Why not use the GitHub Actions action we created specifically for this purpose?:

https://github.com/arduino/compile-sketches

I didn't know about it.
I used it here.
Thanks.

@stefanotorneo
Copy link
Contributor Author

stefanotorneo commented Dec 17, 2025

@per1234 has a valid point, but I would also consider compiling the sketch with profiles in order to be sure the list of libraries in the examples is correct, and there isn't any one missing.

Since in each sketch folder there is a sketch.yaml with platform and profile specified, is it necessary to specify them in the compile-sketches step config?

@lucarin91
Copy link
Contributor

@per1234 has a valid point, but I would also consider compiling the sketch with profiles in order to be sure the list of libraries in the examples is correct, and there isn't any one missing.

Since in each sketch folder there is a sketch.yaml with platform and profile specified, is it necessary to specify them in the compile-sketches step config?

I would just specify the fqbn, i.e., arduino:zephyr:unoq, which was recently removed from the profile

@stefanotorneo
Copy link
Contributor Author

@per1234 has a valid point, but I would also consider compiling the sketch with profiles in order to be sure the list of libraries in the examples is correct, and there isn't any one missing.

Since in each sketch folder there is a sketch.yaml with platform and profile specified, is it necessary to specify them in the compile-sketches step config?

I would just specify the fqbn, i.e., arduino:zephyr:unoq, which was recently removed from the profile

Okay, I did it.

@stefanotorneo stefanotorneo force-pushed the stefanotorneo/check-sketches-deps branch from c7be1c3 to e4605ff Compare December 18, 2025 13:49
@stefanotorneo stefanotorneo force-pushed the stefanotorneo/check-sketches-deps branch from b07ab0e to f5680a6 Compare December 18, 2025 14:27
@stefanotorneo stefanotorneo changed the title add ci workflow to check sketches deps add ci workflow to check that sketches compile Dec 18, 2025
@stefanotorneo stefanotorneo changed the title add ci workflow to check that sketches compile Add CI workflow to check that sketches compile Dec 18, 2025
@stefanotorneo stefanotorneo merged commit c88729b into main Dec 18, 2025
5 checks passed
@stefanotorneo stefanotorneo deleted the stefanotorneo/check-sketches-deps branch December 18, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants