Skip to content

fv crate#683

Closed
g-r-a-n-t wants to merge 1 commit intoargotorg:masterfrom
g-r-a-n-t:runtime-output
Closed

fv crate#683
g-r-a-n-t wants to merge 1 commit intoargotorg:masterfrom
g-r-a-n-t:runtime-output

Conversation

@g-r-a-n-t
Copy link
Collaborator

@g-r-a-n-t g-r-a-n-t commented Mar 2, 2022 •
edited
Loading

  • added a runtimeBytecode output option. e.g. fe foo.fe --emit runtimeBytecode
  • created a fe-fv crate and added some contract verification tests

To-Do

  • OPTIONAL: Update Spec if applicable
  • Add entry to the release notes (may forgo for trivial changes)
  • Clean up commit history

@g-r-a-n-t g-r-a-n-t marked this pull request as draft March 2, 2022 21:28
@g-r-a-n-t g-r-a-n-t changed the title runtime output fv crate Mar 7, 2022
g-r-a-n-t
g-r-a-n-t commented Mar 10, 2022
View reviewed changes
@g-r-a-n-t g-r-a-n-t force-pushed the runtime-output branch 3 times, most recently from ec85aa2 to 116acdd Compare March 10, 2022 22:59
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022 •
edited
Loading

Codecov Report

Merging #683 (030f68c) into master (2097ec5) will decrease coverage by 0.02%.
The diff coverage is 84.61%.

❗ Current head 030f68c differs from pull request most recent head 6129e7f. Consider uploading reports for the commit 6129e7f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #683      +/-   ##
==========================================
- Coverage   82.12%   82.10%   -0.03%     
==========================================
  Files         125      125              
  Lines       10849    10887      +38     
==========================================
+ Hits         8910     8939      +29     
- Misses       1939     1948       +9
Impacted Files Coverage Δ
crates/yulgen/src/db.rs 50.00% <ø> (ø)
crates/driver/src/lib.rs 64.38% <53.33%> (-2.86%) ⬇️
crates/yulgen/src/mappers/module.rs 90.00% <90.00%> (ø)
crates/yulc/src/lib.rs 90.32% <100.00%> (+1.86%) ⬆️
crates/yulgen/src/db/queries.rs 100.00% <100.00%> (ø)
crates/yulgen/src/db/queries/contracts.rs 100.00% <100.00%> (ø)
crates/yulgen/src/lib.rs 100.00% <100.00%> (ø)
crates/analyzer/src/context.rs 61.34% <0.00%> (-0.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2097ec5...6129e7f. Read the comment docs.

@g-r-a-n-t g-r-a-n-t force-pushed the runtime-output branch 2 times, most recently from 2e7edf7 to 1ae0965 Compare March 10, 2022 23:36
@g-r-a-n-t g-r-a-n-t marked this pull request as ready for review March 10, 2022 23:40
@g-r-a-n-t g-r-a-n-t marked this pull request as draft March 10, 2022 23:42
@g-r-a-n-t g-r-a-n-t marked this pull request as ready for review March 11, 2022 01:01
@g-r-a-n-t g-r-a-n-t requested review from Y-Nak and sbillig March 11, 2022 01:01
@sbillig
Copy link
Collaborator

sbillig commented Mar 31, 2022

@g-r-a-n-t I haven't been able to get this to work yet. Followed the directions to build kevm and run the fe fv tests. First I got

thread 'sanity_returns_in_cond1' panicked at 'unable to write file: Os { code: 2, kind: NotFound, message: "No such file or directory" }', crates/fv/src/lib.rs:22:40

Solved that with a mkdir ~/src/evm-semantics/tests/specs/fe

Then I got

thread 'sanity_returns_in_cond1' panicked at '[Error] Critical: Does not exist or not a directory:
/home/sean/src/evm-semantics/./tests/specs/erc20/verification/haskell

Did a mkdir ~/src/evm-semantics/tests/specs/erc20/verification/haskell

Then I got

thread 'sanity_returns_in_cond1' panicked at '[Error] Critical: Could not find a compiled definition. Use --directory to
specify one.

So I guess there should be something in evm-semantics/tests/specs/erc20/verification/haskell that I'm missing?

@g-r-a-n-t g-r-a-n-t force-pushed the runtime-output branch 2 times, most recently from 55a91bc to a7aebd0 Compare April 5, 2022 23:54
g-r-a-n-t
g-r-a-n-t commented Apr 5, 2022
View reviewed changes
@g-r-a-n-t
Copy link
Collaborator Author

g-r-a-n-t commented May 24, 2023

#887

@g-r-a-n-t g-r-a-n-t closed this May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbillig sbillig Awaiting requested review from sbillig

@Y-Nak Y-Nak Awaiting requested review from Y-Nak

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@g-r-a-n-t @codecov-commenter @sbillig