Skipping flaky openzeppelin tests - #13976
Merged
Merged
Conversation
cameel
approved these changes
Feb 15, 2023
cameel
left a comment
cameel
left a comment
Collaborator
There was a problem hiding this comment.
If it passes tests, it's good.
Contributor
|
Should be fixed upstream now. |
Collaborator
|
Great! @r0qs time to revert it :P |
Member
Author
|
Already have a branch with it but now solcjs decided to crash: https://app.circleci.com/pipelines/github/ethereum/solidity/28527/workflows/da301c52-c14b-45f2-9632-f2e1133b5b63/jobs/1266470 I'm looking into it haha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13975
This PR adds a workaround to skip the failed external tests that I could reproduce.
Note that as the tests randomly fail, we may need to skip the whole governor tests or all the ones that is using the openzeppelin's test/helpers/time.js.
The problem is already being fixed by openzeppelin though. See OpenZeppelin/openzeppelin-contracts#4046 for reference.