Fix source reference extractor for multi-byte characters - #16914
Open
clonker wants to merge 2 commits into
Open
Conversation
clonker
force-pushed
the
fix-invalid-utf8-source-reference-extractor
branch
2 times, most recently
from
August 13, 2026 07:48
0c8d233 to
3fc5125
Compare
clonker
marked this pull request as ready for review
August 13, 2026 07:48
clonker
force-pushed
the
fix-invalid-utf8-source-reference-extractor
branch
from
August 17, 2026 08:52
3fc5125 to
19d42da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When emitting a warning, we provide a source reference to go with it. If the source is long and contains utf8 characters, it could happen (due to the bytewise treatment), that a multi-byte character was cut in half, causing json serialization to yield an error. This fix moves the caret to the beginning of multi-byte characters when extracting the source reference and it is shortened.