fix(cli): release database connections after commands#26
Merged
Conversation
The CLI never tore down the database driver, so after migrate/seed/etc. finished the pg connection pool kept the Node event loop alive and the process hung for seconds (up to the pool's idle/keepalive timeout) before exiting. - Add an optional dispose() to the DatabaseAdapter contract. The Kysely adapter destroys its Kysely instance (ending the pool); the Prisma compatibility adapter calls $disconnect(). - Add disposeArkormRuntime(): tears down the configured adapter and/or client (Prisma $disconnect, Kysely destroy, or a bare pool end), avoiding double-closing a client an adapter already owns, and swallowing teardown errors during shutdown. - The CLI entrypoint drains the runtime in a finally after every command, so it exits promptly. Tests: unit coverage for disposeArkormRuntime resolution + a postgres e2e asserting the pool is actually ended (pool.ended) after dispose.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI never tore down the database driver, so after migrate/seed/etc. finished the pg connection pool kept the Node event loop alive and the process hung for seconds (up to the pool's idle/keepalive timeout) before exiting.
Tests: unit coverage for disposeArkormRuntime resolution + a postgres e2e asserting the pool is actually ended (pool.ended) after dispose.