fix(cli): rollback --step default + surface query error causes#30
Merged
Conversation
Two CLI regressions found by running the built CLI against Postgres:
- migrate:rollback with no --step failed with '--step must be a positive
integer'. musket returns an empty string (not undefined) for a declared but
unpassed value option, so Number('') = 0 tripped the validation. Treat
null/undefined/'' alike as 'not provided' (default: the last batch). The
test option mocks hid this by returning undefined for unset options.
- The db command printed only the generic 'Raw query execution failed for the
Kysely adapter' wrapper, hiding the real error. It now appends the
underlying cause (e.g. 'relation "x" does not exist').
Tests: rollback with step='' rolls back the last batch; db appends the cause
behind a wrapper error.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two CLI regressions found by running the built CLI against Postgres:
migrate:rollback with no --step failed with '--step must be a positive integer'. musket returns an empty string (not undefined) for a declared but unpassed value option, so Number('') = 0 tripped the validation. Treat null/undefined/'' alike as 'not provided' (default: the last batch). The test option mocks hid this by returning undefined for unset options.
The db command printed only the generic 'Raw query execution failed for the Kysely adapter' wrapper, hiding the real error. It now appends the underlying cause (e.g. 'relation "x" does not exist').
Tests: rollback with step='' rolls back the last batch; db appends the cause behind a wrapper error.