Skip to content

added testing line for CNCF, crosslinked CNCF COC.#4903

Open
sarhiri wants to merge 2 commits into
armadaproject:masterfrom
sarhiri:CNCF_contributing_docs
Open

added testing line for CNCF, crosslinked CNCF COC.#4903
sarhiri wants to merge 2 commits into
armadaproject:masterfrom
sarhiri:CNCF_contributing_docs

Conversation

@sarhiri

@sarhiri sarhiri commented May 11, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

CNCF incubation housekeeping task.

What this PR does / why we need it

  • Adds a Testing section to CONTRIBUTING.md documenting that all new functionality must include tests and that CI runs the test suite automatically on every PR
  • Adds a Code of Conduct cross-link to CONTRIBUTING.md pointing to CNCF Code of Conduct as per CNCF Incubation requirements

Which issue(s) this PR fixes

Fixes # N/A

Special notes for your reviewer

Signed-off-by: sarhiri <143043927+sarhiri@users.noreply.github.com>
@greptile-apps

greptile-apps Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds two housekeeping documentation changes required for CNCF incubation: a cross-link to the CNCF Code of Conduct in CODE_OF_CONDUCT.md, and two new sections in CONTRIBUTING.md covering testing expectations and a Code of Conduct reference.

  • CODE_OF_CONDUCT.md: Inserts a single sentence at line 9 declaring that Armada adheres to the CNCF Code of Conduct, with a link to https://github.com/cncf/foundation/blob/main/code-of-conduct.md.
  • CONTRIBUTING.md — Testing section: Documents that all new functionality must include tests and that CI runs them automatically on every PR.
  • CONTRIBUTING.md — Code of Conduct section: Adds a top-level section (after Security, before License) linking readers to the project's CODE_OF_CONDUCT.md.

Confidence Score: 5/5

Documentation-only change with no code or configuration impact; safe to merge.

Both files receive small, self-contained additions — a reference sentence in CODE_OF_CONDUCT.md and two new sections in CONTRIBUTING.md. All links point to valid, stable URLs. No logic, configuration, or behaviour is touched.

No files require special attention.

Important Files Changed

Filename Overview
CODE_OF_CONDUCT.md Adds a single sentence (line 9) referencing the CNCF Code of Conduct with a valid GitHub link, placed appropriately before the existing sections.
CONTRIBUTING.md Adds a Testing subsection under Contributing Guide and a top-level Code of Conduct section linking to the project's CODE_OF_CONDUCT.md; both additions are correct and well-placed.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[CONTRIBUTING.md] -->|links to| B[CODE_OF_CONDUCT.md]
    B -->|adheres to| C[CNCF Code of Conduct\ngithub.com/cncf/foundation]
    A -->|Testing section| D[CI runs full test suite\non every PR]
    A -->|Code of Conduct section| B
Loading

Reviews (2): Last reviewed commit: "Merge branch 'master' into CNCF_contribu..." | Re-trigger Greptile

@sarhiri sarhiri force-pushed the CNCF_contributing_docs branch from ba3366d to 01ee2d9 Compare May 11, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant