Skip to content

Document that user-specified job deadlines have no maximum#4938

Open
EoinTrial wants to merge 1 commit into
armadaproject:masterfrom
EoinTrial:docs/job-deadlines-no-maximum
Open

Document that user-specified job deadlines have no maximum#4938
EoinTrial wants to merge 1 commit into
armadaproject:masterfrom
EoinTrial:docs/job-deadlines-no-maximum

Conversation

@EoinTrial

Copy link
Copy Markdown
Contributor

What type of PR is this?

Documentation

What this PR does / why we need it

Currently, the 'Job deadlines' section documents the CPU/GPU defaults, but does not mention that user-specified deadlines are uncapped. This PR adds a clarifying sentence to make that explicit.

Which issue(s) this PR fixes

N/A

Special notes for your reviewer

Context: https://gresearch-internal.slack.com/archives/C05CW12SSJK/p1780069152884609

@greptile-apps

greptile-apps Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds a single clarifying sentence to the "Job deadlines" section of the scheduling documentation, making it explicit that Armada imposes no upper bound on user-specified ActiveDeadlineSeconds values.

  • Adds a sentence stating that user-specified deadlines are uncapped, complementing the existing explanation of default deadlines and their behavior.
  • Appends a trailing newline at the end of the file (minor formatting artifact).

Confidence Score: 5/5

Documentation-only change with no code impact; safe to merge.

The change is a single prose addition to a markdown documentation file. It introduces no code paths, configuration changes, or behavioral modifications — only a clarifying note about an existing behavior.

No files require special attention.

Important Files Changed

Filename Overview
docs/scheduling_and_preempting_jobs.md Documentation-only change: adds a clarifying sentence that user-specified ActiveDeadlineSeconds values are not capped by Armada.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Job submitted] --> B{Has ActiveDeadlineSeconds set?}
    B -- No --> C[Armada assigns default deadline\nCPU/GPU-specific default]
    B -- Yes --> D[Use user-specified value\nNo maximum enforced]
    C --> E[Job runs up to deadline,\nthen killed]
    D --> E
Loading

Reviews (2): Last reviewed commit: "Document that user-specified job deadlin..." | Re-trigger Greptile

Signed-off-by: Eoin Shaughnessy <eoinsh@gmail.com>
@EoinTrial EoinTrial force-pushed the docs/job-deadlines-no-maximum branch from a76e34e to e1548bc Compare June 1, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant