Document that user-specified job deadlines have no maximum#4938
Open
EoinTrial wants to merge 1 commit into
Open
Document that user-specified job deadlines have no maximum#4938EoinTrial wants to merge 1 commit into
EoinTrial wants to merge 1 commit into
Conversation
Contributor
Greptile SummaryThis PR adds a single clarifying sentence to the "Job deadlines" section of the scheduling documentation, making it explicit that Armada imposes no upper bound on user-specified
Confidence Score: 5/5Documentation-only change with no code impact; safe to merge. The change is a single prose addition to a markdown documentation file. It introduces no code paths, configuration changes, or behavioral modifications — only a clarifying note about an existing behavior. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Job submitted] --> B{Has ActiveDeadlineSeconds set?}
B -- No --> C[Armada assigns default deadline\nCPU/GPU-specific default]
B -- Yes --> D[Use user-specified value\nNo maximum enforced]
C --> E[Job runs up to deadline,\nthen killed]
D --> E
Reviews (2): Last reviewed commit: "Document that user-specified job deadlin..." | Re-trigger Greptile |
Signed-off-by: Eoin Shaughnessy <eoinsh@gmail.com>
a76e34e to
e1548bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Documentation
What this PR does / why we need it
Currently, the 'Job deadlines' section documents the CPU/GPU defaults, but does not mention that user-specified deadlines are uncapped. This PR adds a clarifying sentence to make that explicit.
Which issue(s) this PR fixes
N/A
Special notes for your reviewer
Context: https://gresearch-internal.slack.com/archives/C05CW12SSJK/p1780069152884609