chore: remove afnetworkactivitylogger#13293
Merged
brainbicycle merged 3 commits intomainfrom Mar 2, 2026
Merged
Conversation
brainbicycle
commented
Feb 26, 2026
| isa = PBXGroup; | ||
| children = ( | ||
| 4C1B6860831AE690075CFD4C /* Pods_ArtsyTests.framework */, | ||
| A1B2C3D4E5F600AABB000001 /* ios-config.json */, |
Contributor
Author
There was a problem hiding this comment.
i don't think i touched anything here, possibly got removed in a previous pr? or Xcode version churn? let me know if this shouldn't be here though
Member
There was a problem hiding this comment.
I get this also from time to time I think since this https://github.com/artsy/eigen/pull/13263/changes#diff-dd554256dd5310d0a87054f5199528bfe3d5a8aa240cd85dcee26f4d5a502b43 was added.
now if I pull from main and build with xcode I no longer get it 🤷
Contributor
Author
There was a problem hiding this comment.
let me merge main and build and see if it goes away 👍
Contributor
Author
There was a problem hiding this comment.
it did not go away 👀, going to merge and see if this comes up again
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves PHIRE-2833
Description
Removes AFNetworkActivityLogger pod, this is only used on the native side to add logs when sending network requests, I don't think anyone uses these for debugging these days, can use network tab in react native debugger or other dedicated network debugging tools.
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.