-
Notifications
You must be signed in to change notification settings - Fork 3
Removed tokio-console from main.rs and Dockerfile. Logging still works as before. #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed tokio-console from main.rs and Dockerfile. Logging still works as before. #223
Conversation
lfbrehm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thank you for contributing! This looks great so far. One remaining issue here is the removal of the -crt-static flag in our components/data_proxy/Dockerfile. You can check if the container builds with docker build -f components/data_proxy/Dockerfile ..
lfbrehm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, you have added the --cfg tokio_unstable option back in, which we wanted to remove in the first place.
|
One additional comment: can you please in the end squash your commits into a single commit that complies with the semantic commits standard. So something in the line of:
|
e76f35d to
1d2884f
Compare
Sorry for the inconvenience on my side. I’ve fixed this again and verified it by running docker build; the image now builds successfully without any errors.
I have squashed all the commits into one as you specified while following the semantic standard. Thank you again to both of you for your invaluable guidance!! |
lfbrehm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now! Thanks again for contributing!
This PR is raised against the issue id - #222