Skip to content

Conversation

@param-jasani
Copy link
Contributor

This PR is raised against the issue id - #222

Copy link
Member

@lfbrehm lfbrehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thank you for contributing! This looks great so far. One remaining issue here is the removal of the -crt-static flag in our components/data_proxy/Dockerfile. You can check if the container builds with docker build -f components/data_proxy/Dockerfile ..

@param-jasani param-jasani requested a review from lfbrehm December 18, 2025 18:55
Copy link
Member

@lfbrehm lfbrehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, you have added the --cfg tokio_unstable option back in, which we wanted to remove in the first place.

@St4NNi
Copy link
Member

St4NNi commented Dec 19, 2025

One additional comment:

can you please in the end squash your commits into a single commit that complies with the semantic commits standard. So something in the line of:

chore: remove tokio-console from dataproxy

@param-jasani param-jasani force-pushed the tokio-console-dependency-removal branch from e76f35d to 1d2884f Compare December 19, 2025 21:06
@param-jasani
Copy link
Contributor Author

Now, you have added the --cfg tokio_unstable option back in, which we wanted to remove in the first place.

Sorry for the inconvenience on my side. I’ve fixed this again and verified it by running docker build; the image now builds successfully without any errors.

One additional comment:

can you please in the end squash your commits into a single commit that complies with the semantic commits standard. So something in the line of:

chore: remove tokio-console from dataproxy

I have squashed all the commits into one as you specified while following the semantic standard.

Thank you again to both of you for your invaluable guidance!!

@param-jasani param-jasani requested a review from lfbrehm December 19, 2025 21:12
Copy link
Member

@lfbrehm lfbrehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now! Thanks again for contributing!

@lfbrehm lfbrehm merged commit 9a10bc7 into arunaengine:main Dec 22, 2025
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants