feat(irx): add utf8 and large_utf8 string columns to record batch#93
Open
yogendra-17 wants to merge 2 commits into
Open
feat(irx): add utf8 and large_utf8 string columns to record batch#93yogendra-17 wants to merge 2 commits into
yogendra-17 wants to merge 2 commits into
Conversation
yuvimittal
reviewed
Jul 14, 2026
| return IRX_OK; | ||
| } | ||
|
|
||
| int irx_rb_batch_get_utf8(const IrxRbBatch *b, int col, int64_t row, |
Member
There was a problem hiding this comment.
on a null slot this returns an empty view rather than an error. That's consistent with the numeric getters, so no change needed here, but please add a line to the get_string docstring in record_batch.py telling callers to check is_null first.
| builder.release() | ||
| schema.release() | ||
|
|
||
| def test_wrong_column_type_raises(self): |
Member
There was a problem hiding this comment.
This tests the append-side type mismatch, but the get-side branch (irx_rb_batch_get_utf8 on a non-string column) is untested, add a case that builds an INT32 batch and asserts get_string raises.
Member
|
@yogendra-17 , can you please rebase your branch ? The core design is correct, thanks for working on that. I have added some small comments, but we can push them later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request description
This PR adds string columns so IRx record batches can hold text, still fully Arrow-compatible.
What changed
append_string(...)to write text andget_string(...)to read it back handles any language and emoji (multi-byte UTF-8), empty strings, and null/missing values.irx_record_batch.cpp/.h), the Python ctypes wrapper (irx/record_batch.py), and the RuntimeFeature symbol table(builder/runtime/record_batch.py) so compiled IRx programs get the symbols too.How to test these changes
...Pull Request checklists
This PR is a:
About this PR:
Author's checklist:
complexity.
Additional information
This is the string half of (string + temporal types), built on the Arrow C++ bridge from #88. Temporal types (date/timestamp) follow in a separate PR to keep this one small and reviewable.
Reviewer's checklist
Copy and paste this template for your review's note: