Skip to content

switch decode source encoding from ascii to utf-8 - #130

Open
freddez wants to merge 3 commits into
aschn:masterfrom
freddez:master
Open

switch decode source encoding from ascii to utf-8#130
freddez wants to merge 3 commits into
aschn:masterfrom
freddez:master

Conversation

@freddez

@freddez freddez commented Nov 22, 2018

Copy link
Copy Markdown

UnicodeDecodeError fix on python 2.7 / django 1.11 #129

Tested with Python 2.7.15 / Django 1.11.16 and Python 2.3.7 / Django 2.1.3

@mrdaliri

Copy link
Copy Markdown

Could you please update it with latest master branch? Another parameter (errors='replace') has been added to data.decode().

@martync

martync commented Aug 27, 2019

Copy link
Copy Markdown

Hi !
I was wondering if there's something blocking this pull-request. I saw a pyFlake error on travis , how can I help ?

@avelis

avelis commented Aug 27, 2019

Copy link
Copy Markdown
Collaborator

@martync Fix the pyFlake would help here I think. It also has merge conflicts.

@martync

martync commented Aug 28, 2019

Copy link
Copy Markdown

I can't reproduce this error at home nor on travis : tests/test_mixins.py:385:13: E117 over-indented

I have another failure that concerns pypi (which is normal) : https://github.com/martync/drf-tracking/commits/master but no pyflake errors here 🤔

@avelis can you re-trigger this travis build ? If it still fails, I'll make a pull request from my repo

@avelis

avelis commented Aug 28, 2019

Copy link
Copy Markdown
Collaborator

@martync I restarted it. You can follow its progress here: https://travis-ci.org/aschn/drf-tracking/builds/531659171

@martync

martync commented Nov 27, 2019

Copy link
Copy Markdown

Hi @avelis any chance you have time to create a new release with this fix ?

@avelis

avelis commented Nov 27, 2019

Copy link
Copy Markdown
Collaborator

@martync I can try and take a look after the holiday break.

@avelis

avelis commented Dec 21, 2019

Copy link
Copy Markdown
Collaborator

@martync This needs a rebase in order to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants