Skip to content

fix(ipx): make ipx transform work with a remote base url #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ascorbic merged 2 commits into from
Jul 13, 2025
Merged

fix(ipx): make ipx transform work with a remote base url #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59d2d0b
fix: Make ipx transform work with a remote base url
Ventinc Jul 12, 2025
bd14d30
fix: use stripTrailingSlash
Ventinc Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/providers/ipx.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import { assertEquals } from "jsr:@std/assert";
const absoluteImg = "https://example.com/images/test.jpg";
const img = "/images/test.jpg";
const baseURL = "https://example.com/_ipx";
const remoteBaseUrl = "https://ipx.example.com";


Deno.test("ipx extract", async (t) => {
await t.step("should extract operations from a URL", () => {
Expand Down Expand Up @@ -122,4 +124,19 @@ Deno.test("ipx transform", async (t) => {
`/_ipx/s_300x200,f_auto/https://example.com/images/test.jpg`,
);
});

await t.step("should work with ipx as a remote service baseURL", () => {
const result = transform(
absoluteImg,
{
width: 300,
height: 200,
},
{ baseURL: remoteBaseUrl },
);
assertEqualIgnoringQueryOrder(
result,
`${remoteBaseUrl}/s_300x200,f_auto/https://example.com/images/test.jpg`,
);
});
});
3 changes: 2 additions & 1 deletion src/providers/ipx.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
import {
createOperationsHandlers,
stripLeadingSlash,
stripTrailingSlash,
toCanonicalUrlString,
toUrl,
} from "../utils.ts";
Expand Down Expand Up @@ -74,7 +75,7 @@ export const generate: URLGenerator<"ipx"> = (
const baseURL = options?.baseURL ?? "/_ipx";
const url = toUrl(baseURL);

url.pathname = `${url.pathname}/${modifiers}/${
url.pathname = `${stripTrailingSlash(url.pathname)}/${modifiers}/${
stripLeadingSlash(src.toString())
}`;
return toCanonicalUrlString(url);
Expand Down