Skip to content

Add offset_list and scat_scale support to multi-band/multi-image fitting setup#7

Draft
Copilot wants to merge 10 commits into
mainfrom
copilot/add-offset-list-support
Draft

Add offset_list and scat_scale support to multi-band/multi-image fitting setup#7
Copilot wants to merge 10 commits into
mainfrom
copilot/add-offset-list-support

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 20, 2026

This PR extends ProFuse fitting setup wrappers to better support cross-image alignment and likelihood scatter scaling, while preserving existing behavior when new options are not used.

Changes Made

  • Added offset_list support to profuseMultiBandFound2Fit:
    • normalizes and validates input (NULL, length-1 recycle, or per-band list matching image_list)
    • validates each non-NULL offset element as numeric [X, Y]
    • forwards per-band offsets into profitSetupData(offset=...)
  • Updated multi-band documentation (man/profuseMultiBand.Rd) to include offset_list usage and constraints.
  • Updated vignette wording to reflect that multi-band workflows now support per-band offsets.
  • Reviewed and corrected new scat_scale integration against ProFit profitLikeModel expectations:
    • fixed multi-band bounds logic to check MF2F$parm.names (instead of an undefined Data reference)
  • Added analogous scat_scale support to multi-image workflow:
    • new scat_scale argument in profuseMultiImageFound2Fit
    • appends log_scat_scale to parameter names when enabled
    • adds [-2, 2] bounds for log_scat_scale in profuseMultiImageDoFit
    • includes guard logic for safe bounds checks
  • Added scat_scale documentation to:
    • man/profuseMultiBand.Rd
    • man/profuseMultiImage.Rd

Notes on Validation

  • Automated code review/validation was run and resulting issues were addressed.
  • Local R-based test/check execution was not possible in this environment because R is unavailable.

@asgr
Copy link
Copy Markdown
Owner

asgr commented May 27, 2026

@copilot check the new scat_scale implementation (especially check how it interacts with asgr/ProFit profitLikeModel, which has scat_scale added already). Add relevant documentation, and add similar support in profuseMultiImage.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 27, 2026

@copilot check the new scat_scale implementation (especially check how it interacts with asgr/ProFit profitLikeModel, which has scat_scale added already). Add relevant documentation, and add similar s...

Implemented in commits bd7b296 and ec7dda5.

  • Checked/fixed scat_scale multi-band wiring against ProFit profitLikeModel: the bounds check now correctly uses MF2F$parm.names (fixing the undefined Data reference).
  • Added analogous scat_scale support in profuseMultiImageFound2Fit/profuseMultiImageDoFit (including bounds handling for log_scat_scale).
  • Added relevant documentation for scat_scale in man/profuseMultiBand.Rd and man/profuseMultiImage.Rd.

Copilot AI changed the title noop Add offset_list and scat_scale support to multi-band/multi-image fitting setup May 27, 2026
Copilot finished work on behalf of asgr May 27, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants