Add offset_list and scat_scale support to multi-band/multi-image fitting setup#7
Draft
Copilot wants to merge 10 commits into
Draft
Add offset_list and scat_scale support to multi-band/multi-image fitting setup#7Copilot wants to merge 10 commits into
Copilot wants to merge 10 commits into
Conversation
Agent-Logs-Url: https://github.com/asgr/ProFuse/sessions/01d5aec8-11cf-4bf5-97fc-610ab52c296c Co-authored-by: asgr <5617132+asgr@users.noreply.github.com>
Agent-Logs-Url: https://github.com/asgr/ProFuse/sessions/01d5aec8-11cf-4bf5-97fc-610ab52c296c Co-authored-by: asgr <5617132+asgr@users.noreply.github.com>
Agent-Logs-Url: https://github.com/asgr/ProFuse/sessions/01d5aec8-11cf-4bf5-97fc-610ab52c296c Co-authored-by: asgr <5617132+asgr@users.noreply.github.com>
Agent-Logs-Url: https://github.com/asgr/ProFuse/sessions/01d5aec8-11cf-4bf5-97fc-610ab52c296c Co-authored-by: asgr <5617132+asgr@users.noreply.github.com>
Agent-Logs-Url: https://github.com/asgr/ProFuse/sessions/01d5aec8-11cf-4bf5-97fc-610ab52c296c Co-authored-by: asgr <5617132+asgr@users.noreply.github.com>
Agent-Logs-Url: https://github.com/asgr/ProFuse/sessions/01d5aec8-11cf-4bf5-97fc-610ab52c296c Co-authored-by: asgr <5617132+asgr@users.noreply.github.com>
Agent-Logs-Url: https://github.com/asgr/ProFuse/sessions/01d5aec8-11cf-4bf5-97fc-610ab52c296c Co-authored-by: asgr <5617132+asgr@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
asgr
April 20, 2026 08:06
View session
Owner
|
@copilot check the new scat_scale implementation (especially check how it interacts with asgr/ProFit profitLikeModel, which has scat_scale added already). Add relevant documentation, and add similar support in profuseMultiImage. |
Contributor
Author
Implemented in commits
|
Copilot
AI
changed the title
noop
Add offset_list and scat_scale support to multi-band/multi-image fitting setup
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends ProFuse fitting setup wrappers to better support cross-image alignment and likelihood scatter scaling, while preserving existing behavior when new options are not used.
Changes Made
offset_listsupport toprofuseMultiBandFound2Fit:NULL, length-1 recycle, or per-band list matchingimage_list)NULLoffset element as numeric[X, Y]profitSetupData(offset=...)man/profuseMultiBand.Rd) to includeoffset_listusage and constraints.scat_scaleintegration against ProFitprofitLikeModelexpectations:MF2F$parm.names(instead of an undefinedDatareference)scat_scalesupport to multi-image workflow:scat_scaleargument inprofuseMultiImageFound2Fitlog_scat_scaleto parameter names when enabled[-2, 2]bounds forlog_scat_scaleinprofuseMultiImageDoFitscat_scaledocumentation to:man/profuseMultiBand.Rdman/profuseMultiImage.RdNotes on Validation
Ris unavailable.