fix: normalize deps skill names per agentskills.io spec#68
Merged
zachdaniel merged 2 commits intoash-project:mainfrom Apr 5, 2026
Merged
Conversation
phiilu
commented
Apr 4, 2026
Contributor
|
The main thing we need to make sure that this does is remove any skills that used the old naming pattern. Could you add a test that shows that? i.e create an old skill using the old naming pattern w/ the old contents, and test that syncing removes that old skill? I think it will because we use frontmatter to indicate what skills we manage, but I just want to be 100% sure 😄 |
Contributor
Author
|
Makes sense! I will do it as soon as possible. |
ed290c0 to
057719b
Compare
Contributor
Author
|
I added the requested test. Hopefully I did it like you intended it :) |
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Leave anything that you believe does not apply unchecked.
This PR resolves #67
I considered only deps: rules to be normalized automatically. For build: and package_skills: I opted to show a warning, because those could be fixed by the user (build:) or by the maintainer of the dependency (package_skills:).
From my project:
would show a warning for
phoenix_frameworkand update the usage_rules correct:
Spec reference: https://agentskills.io/specification#frontmatter-required