feat: harness engineering — tests, linting, CI, architecture enforcement#7
Merged
Conversation
… enforcement Add mechanical enforcement to Seer following HES v1 principles: - `bun run check` — canonical check command (typecheck + lint + test) - biome v2.4.15 for linting and formatting - 77 tests across 7 files covering scoring, CSV parsing, retry logic, criteria definitions, judge prompt snapshots, architecture boundaries, and full e2e pipeline (guidance + golden + safety + metrics) - Extract prompt builders from judge.ts → judge-prompts.ts (pure functions) - Extract parseCSVLine from cli.ts → lib/csv.ts - Architecture boundary test enforcing 5-layer import constraints - GitHub Actions CI with 3-gate matrix (fail-fast: false) - AGENTS.md as agent-optimized entry point - Development ledger for cross-session continuity Type fixes: any → unknown in API response interfaces, removed unused variables, biome auto-formatting across all src/ files. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Config was evaluated eagerly at module load via `export const config = loadConfig()`, which throws when GLEAN_API_KEY is absent. Changed to lazy singleton `getConfig()` so E2E tests can set dummy env vars before first config access. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds mechanical enforcement to Seer following HES v1 principles. The eval framework that evaluates agent quality now has quality gates of its own.
bun run check— canonical check command (typecheck + lint + test)fail-fast: falseKey refactors (zero behavior change)
judge.ts→judge-prompts.ts(pure functions, snapshot-tested)parseCSVLinefromcli.ts→lib/csv.tsany→unknownin API response interfacesDEFAULT_CONFIGin simulator,agentIdin generate-agent)Test plan
bun run checkpasses (typecheck + lint + 77 tests)tsc --noEmitfails🤖 Generated with Claude Code