Some connection sanity #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quest headers. Added EventSource state updates for OPEN and CLOSED.
…nto SSL Reverted custom HTTP Header and POM changes
…n we need to reconnect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One fix, two new features:
In cases where the initial connection failed due to a DNS lookup error, the component is no longer able to reconnect even after normal conditions have been restored.
My change re-sets the connection address to cause a new DNS lookup to be performed.
I needed my program to be aware if the connection was down at any point, so I plumbed in the OnClosed event to provide notifications of this, along with a "WillReconnect" indicator.
Thanks to Dan Noguerol for doing all of the legwork. I simply fixed one or two things so that it would work well in my environment.