Skip to content

fix: materialize namespace packages concretely in venv site-packages#1088

Draft
jbedard wants to merge 2 commits into
mainfrom
oai-3
Draft

fix: materialize namespace packages concretely in venv site-packages#1088
jbedard wants to merge 2 commits into
mainfrom
oai-3

Conversation

@jbedard

@jbedard jbedard commented Jun 6, 2026

Copy link
Copy Markdown
Member

See #1092 instead

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases
  • New test cases added

@jbedard jbedard requested review from gregmagolan and xangcastle June 6, 2026 05:10
@aspect-workflows

aspect-workflows Bot commented Jun 6, 2026

Copy link
Copy Markdown

✨ Aspect Workflows Tasks

📅 Mon Jun 8 02:14:17 UTC 2026

✅ 7 successful tasks

  • ✅ buildifier · ⏱ 16.5s · 🐙 GitHub Actions · ☑️ Check
    💬 Format complete (clean)
  • ✅ gazelle · ⏱ 24.5s · 🐙 GitHub Actions · ☑️ Check
    💬 Gazelle complete (clean)
  • ✅ test (test-e2e-bazel-8) · ⏱ 2m 9s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (140/140 passed)
  • ✅ test (test-e2e-bazel-9) · ⏱ 3m 4s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (135/135 passed)
  • ✅ test (test-examples-uv_pip_compile-bazel-8) · ⏱ 30.2s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed · 1 cached)
  • ✅ test (test-root-bazel-8) · ⏱ 2m 8s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (184/184 passed)
  • ✅ test (test-root-bazel-9) · ⏱ 1m 49s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (183/183 passed)

⏱ Last updated Mon Jun 8 02:18:13 UTC 2026 · 📊 GitHub API quota 791/15,000 (5% used, resets in 35m)
🚀 Powered by Aspect CLI (v2026.22.44)  |  Aspect Build · X · LinkedIn · YouTube

@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown

py_binary startup benchmark

Version Mean (ms) Median (ms) ± stddev vs BCR vs main Build (s)
BCR 1.11.5 (baseline) 324.299 322.768 ±8.777 42.56
HEAD main 61.912 61.967 ±0.894 -80.9% 11.91
This PR 61.686 61.477 ±1.059 -81.0% -0.4% 10.84

Measured with hyperfine --warmup 5 --runs 50 on Linux
Gate: PR vs HEAD main (threshold: 10%). BCR is shown only as a historical baseline.
Build time: cold bazel build //:bench with isolated output base, no disk cache.

sys.path quality

Version sys.path entries distinct site-packages roots duplicate realpaths
BCR 1.11.5 (baseline) 6 1 0
HEAD main 7 2 0
This PR 7 2 0

sys.path quality measured by bench_syspath inside the assembled venv. Duplicate realpaths indicate symlink redundancy; many distinct site-packages roots suggest an inefficient venv layout.

@jbedard jbedard marked this pull request as draft June 7, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant