Skip to content

fix: regular package spanning two wheels (azure-core + azure-core-tracing-opentelemetry) is importable#1090

Draft
jbedard wants to merge 2 commits into
mainfrom
oai-azure
Draft

fix: regular package spanning two wheels (azure-core + azure-core-tracing-opentelemetry) is importable#1090
jbedard wants to merge 2 commits into
mainfrom
oai-azure

Conversation

@jbedard

@jbedard jbedard commented Jun 6, 2026

Copy link
Copy Markdown
Member

See #1092 instead

Changes are visible to end-users: yes/no

  • Searched for relevant documentation and updated as needed: yes/no
  • Breaking change (forces users to change their own code or config): yes/no
  • Suggested release notes appear below: yes/no

Test plan

  • Covered by existing test cases
  • New test cases added
  • Manual testing; please provide instructions so we can reproduce:

@aspect-workflows

aspect-workflows Bot commented Jun 6, 2026

Copy link
Copy Markdown

✨ Aspect Workflows Tasks

📅 Sat Jun 6 20:02:18 UTC 2026

✅ 7 successful tasks

  • ✅ buildifier · ⏱ 19.9s · 🐙 GitHub Actions · ☑️ Check
    💬 Format complete (clean)
  • ✅ gazelle · ⏱ 17.8s · 🐙 GitHub Actions · ☑️ Check
    💬 Gazelle complete (clean)
  • ✅ test (test-e2e-bazel-8) · ⏱ 2m 8s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (143/143 passed)
  • ✅ test (test-e2e-bazel-9) · ⏱ 2m 12s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (138/138 passed)
  • ✅ test (test-examples-uv_pip_compile-bazel-8) · ⏱ 27.1s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed · 1 cached)
  • ✅ test (test-root-bazel-8) · ⏱ 1m 54s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (184/184 passed)
  • ✅ test (test-root-bazel-9) · ⏱ 2m 13s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (183/183 passed)

⏱ Last updated Sat Jun 6 20:06:21 UTC 2026 · 📊 GitHub API quota 29/15,000 (0% used, resets in 47m)
🚀 Powered by Aspect CLI (v2026.22.44)  |  Aspect Build · X · LinkedIn · YouTube

@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown

py_binary startup benchmark

Version Mean (ms) Median (ms) ± stddev vs BCR vs main Build (s)
BCR 1.11.5 (baseline) 291.862 290.237 ±7.198 39.07
HEAD main 55.818 55.634 ±0.642 -80.9% 12.13
This PR 55.943 55.880 ±0.593 -80.8% +0.2% 10.53

Measured with hyperfine --warmup 5 --runs 50 on Linux
Gate: PR vs HEAD main (threshold: 10%). BCR is shown only as a historical baseline.
Build time: cold bazel build //:bench with isolated output base, no disk cache.

sys.path quality

Version sys.path entries distinct site-packages roots duplicate realpaths
BCR 1.11.5 (baseline) 6 1 0
HEAD main 7 2 0
This PR 7 2 0

sys.path quality measured by bench_syspath inside the assembled venv. Duplicate realpaths indicate symlink redundancy; many distinct site-packages roots suggest an inefficient venv layout.

@jbedard jbedard changed the title test: regular package spanning two wheels (azure-core + azure-core-tracing-opentelemetry) is importable fix: regular package spanning two wheels (azure-core + azure-core-tracing-opentelemetry) is importable Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant