Skip to content

feat: port pytest_test macro#401

Merged
alexeagle merged 1 commit into
mainfrom
pytest
Feb 13, 2025
Merged

feat: port pytest_test macro#401
alexeagle merged 1 commit into
mainfrom
pytest

Conversation

@alexeagle

@alexeagle alexeagle commented Oct 3, 2024

Copy link
Copy Markdown
Contributor

Comes from caseyduquettesc/rules_python_pytest#13 It's much easier to properly gazelle-generate a BUILD file in this shape rather than the awkward way you're forced to hold our py_pytest_main.

@alexeagle alexeagle requested review from jbedard and mattem October 3, 2024 16:16
alexeagle
alexeagle commented Oct 3, 2024
View reviewed changes
Comment thread pytest/pytest_shim.py Outdated
mattem
mattem reviewed Oct 3, 2024
View reviewed changes
Comment thread pytest/pytest_shim.py Outdated
Comment thread pytest/pytest_shim.py Outdated
Comment thread pytest/defs.bzl Outdated
Comment thread pytest/defs.bzl Outdated
Comment thread pytest/defs.bzl Outdated
Comment thread pytest/defs.bzl Outdated
Comment thread pytest/defs.bzl Outdated
Comment thread pytest/pytest_shim.py Outdated
@alexeagle

alexeagle commented Oct 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I have very little time to prepare a talk for Monday and I think you're expecting a higher level of polish than Casey had, so I'm going to try the bazel-contrib/rules_python#2044 approach instead

@alexeagle alexeagle mentioned this pull request Oct 4, 2024
Open
@alexeagle alexeagle mentioned this pull request Jan 21, 2025
Merged
@github-actions

github-actions Bot commented Jan 28, 2025 •
edited
Loading

Copy link
Copy Markdown

e2e/use_release folder: LCOV of commit 826d536 during CI #1680

Summary coverage rate:
  lines......: 100.0% (2 of 2 lines)
  functions..: 100.0% (1 of 1 function)
  branches...: no data found

Files changed coverage rate: n/a

@aspect-workflows

aspect-workflows Bot commented Jan 28, 2025 •
edited
Loading

Copy link
Copy Markdown

Test

All tests were cache hits

30 tests (100.0%) were fully cached saving 51s.

@alexeagle alexeagle requested a review from thesayyn January 29, 2025 04:08
@alexeagle
feat: py_test macro generates a py_pytest_main
826d536 
Provides much-needed syntax sugar for this common case.
@alexeagle alexeagle merged commit 6ad4667 into main Feb 13, 2025
@alexeagle alexeagle deleted the pytest branch February 13, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thesayyn thesayyn thesayyn approved these changes

@jbedard jbedard Awaiting requested review from jbedard

+2 more reviewers

@mattem mattem mattem left review comments

@caseyduquettesc caseyduquettesc caseyduquettesc left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexeagle @mattem @caseyduquettesc @thesayyn