Skip to content

Get rid of file _version.py#411

Closed
DimitriPapadopoulos wants to merge 1 commit into
astanin:masterfrom
DimitriPapadopoulos:version
Closed

Get rid of file _version.py#411
DimitriPapadopoulos wants to merge 1 commit into
astanin:masterfrom
DimitriPapadopoulos:version

Conversation

@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor

This was useful for running __init__.py as as script, but since AppVeyor has been removed, it is certainly not used any more.

In any case, it shouldn't be used. Whatever your need, try editable installs:

pip install -e .

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as draft March 5, 2026 14:10
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.19%. Comparing base (6050bef) to head (58764e9).
⚠️ Report is 9 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
+ Coverage   84.17%   84.19%   +0.01%     
==========================================
  Files           1        1              
  Lines         891      892       +1     
  Branches      217      217              
==========================================
+ Hits          750      751       +1     
  Misses        107      107              
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DimitriPapadopoulos DimitriPapadopoulos force-pushed the version branch 2 times, most recently from 87df25d to 234d918 Compare March 5, 2026 14:34
This was useful for running `__init__.py` as as script, but since AppVeyor
has been removed, it is certainly not used any more.

In any case, it shouldn't be used. Whatever your need, try editable installs:
	pip install -e .

Because `flit_scm:buildapi` delegates to `setuptools-scm` for version
discovery, we need to enable it with:
	[tool.setuptools_scm]

More importantly, this fixes the build backend, which was wrong!
	flit → flit_core
@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor Author

This cannot work. Because .git is not part of isolated environments, we need to write the version to a file beforehand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants