Skip to content

Conversation

@brandonzylstra
Copy link

If I understood the intention of the example, I think this is what was meant.

If I understood the intention of the example, I think this is what was meant.
Copilot AI review requested due to automatic review settings January 5, 2026 16:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to fix the expected HTML output in the README.md example by changing the heading tags to match their corresponding aria-level attributes (e.g., <h1 aria-level="1"> instead of <h3 aria-level="1">). However, this creates a critical discrepancy with the actual component implementation.

Key Issue:

  • The Heading.astro component (shown in the README and confirmed in demo/src/components/Heading.astro) always renders an <h3> tag with a dynamic aria-level attribute
  • The "corrected" output now shows varying heading tags (<h1>, <h2>, <h3>, <h4>) that the component cannot actually produce

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +106 to +118
<h1 aria-level="1">Title</h1>
<p>This section uses a heading of level 1.</p>

<section>
<h3 aria-level="2">Heading</h3>
<h2 aria-level="2">Heading</h2>
<p>This section uses a heading of level 2.</p>

<section>
<h3 aria-level="3">Sub-Heading</h3>
<p>This section uses a heading of level 3.</p>

<section>
<h3 aria-level="4">Sub-Sub-Heading</h3>
<h4 aria-level="4">Sub-Sub-Heading</h4>
Copy link

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The corrected HTML output shows varying heading tags (h1, h2, h3, h4) that match their aria-level attributes. However, the Heading.astro component implementation shown above (line 65) always renders an h3 tag with a dynamic aria-level attribute. This creates a discrepancy: the actual output would be all h3 tags with different aria-level values, not different heading tags. Either the component implementation should be updated to dynamically select the heading tag (e.g., using a dynamic element or conditional rendering), or the expected output should show h3 tags consistently to accurately reflect what the component actually produces.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant