Pronob's GUI work

[adampbeardsley]

@Maxman0001 I'm creating a (draft) pull request from your branch to make it easier to discuss changes.

[adampbeardsley]

Good crack at it. I've made a bunch of suggestions - mostly taking out commented code. Look over and see if you agree with things. I'll need to get into the lab to try it out and see how it looks.

[adampbeardsley]

Suggested change

	# directory = user+"_"+location+"_"+date_y_m_d+"_"+trial+"_"+time.replace(":", ".")+"_"+tDay
	# New format without location and with latitude and longitude
	# I used f strings here for clarity

Glad you're using f strings, but don't need to include the explanation in the code.
And don't need to say that it's a new format - it will be in the changelog, and having the comment might confuse future devs

[adampbeardsley]

Let's move this function up to the top where other functions are defined.

[adampbeardsley]

Suggested change

	# Adds a small gray hint label that appears only while typing in this entry."""
	""" Adds a small gray hint label that appears only while typing in this entry.
	The goal is to have the hints under the entry or to the side so that the user knows what format to use."""

[adampbeardsley]

Suggested change

	# This function is to add hint labels to entry widgets when the user starts typing
	# the goal is to have the hints under the entry or to the side so that the user knows what format to use
	# def add_hint_label(entry_widget, hint_text, position="below"):
	# #Adds a small gray hint label that appears when the user starts typing.
	# hint_label = customtkinter.CTkLabel(master=app,
	# text=hint_text,
	# text_color="gray50",
	# font=("Arial", 10))
	# hint_label.place_forget() # Hidden until user types
	# def on_type(event):
	# content = entry_widget.get()
	# if content.strip():
	# x, y = entry_widget.winfo_x(), entry_widget.winfo_y()
	# if position == "below":
	# hint_label.place(x=x, y=y + entry_widget.winfo_height() + 2)
	# else: # show beside
	# hint_label.place(x=x + entry_widget.winfo_width() + 5, y=y)
	# else:
	# hint_label.place_forget()
	# # Bind typing events
	# entry_widget.bind("<KeyRelease>", on_type)

[adampbeardsley]

What is content used for?

[adampbeardsley]

Are some of these redundant with the labels that are already there?

[adampbeardsley]

I had a chance to look over and play with the current state, using the raspberry pi setup with the small monitor. Here are a few things I noticed:

• The positioning of the hints could be tweaked. For example, sometimes they get in the way of the next box:
  While this example doesn't completely cover the box, it reduces the space to click, and covers up the formatting hint, which hinders the flow of filling it out. As you go down in the form, the hints tend to drift further down. By the end they're quite out of place.
• The Time hint is all the way in the upper left.
• With the new layout, it's unclear what boxes "Use Default Parameters" affects. Previously it was everything above the actual toggle, but now all the boxes are above it.
• I can't use the mouse's scroll wheel to scroll. I have to click and drag the marker within the scroll bar.

There are a few other issues I found, but when going back to the master branch I realized they existed there. So I'll open separate issues for them.

And a followup question: with the new formatting, is it now possible to include a font-size option to dynamically change? Personally I like the font size, but some users have complained they want bigger font. So it would be cool to have an option.

[adampbeardsley]

A couple notes from testing out the latest changes:

• When the window switches to two columns, personally I would prefer for the flow to go down the first column, then the second. But I'd like to hear what others have to say.
• Could we set the default window size so when it opens on the small screen it's in the two-column format? Personally I find that a lot nicer to work with.