You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm actually also getting the AttributeError: 'PCB_TEXT' object has no attribute 'SetThickness' error on KiCad 6 (specifically: (6.0.6-1)-1) on MacOS.
I checked, and SWIG_version is indeed 6 on my setup.
Changing SetThickness to SetTextThickness works.
I'd thus recommend changing this PR's references to if SWIG_version >= 7 to if SWIG_version >= 6.
Also, is there anything else blocking this PR from getting merged ? If so, I'm up to work on it.
I like this change. Sorry I overlooked it for a while. mirrored will be a good addition, and the >=6 bug is still in there. There is some refactoring going on now, so the location of these edits moved to item.py:TextEsque. @tannewt , it is probably easiest to make a new PR based off of a fresh main branch. I will keep an eye out for one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.