Add specific driver for Vimar Touch Thermostats of type 02952.b#29
Add specific driver for Vimar Touch Thermostats of type 02952.b#29petero-dk wants to merge 17 commits intoathombv:masterfrom
Conversation
|
Excuse the delay, We are discussing this internally |
No problem, no rush for me. |
There was a problem hiding this comment.
Don't forget to translate the setting labels/hints and the flow labels to dutch if you are able to.
Also it would be nice to have a custom icon and images for this device. You can request the icon here: https://github.com/athombv/homey-vectors-public
That can set the shift to 0 and thus resetting the setpoint to the base of current mode
petero-dk
force-pushed
the
device/vimar_thermostat
branch
from
24fd9b0 to
d32c664
Compare
Did you ever determine whether this would be better as part of the knx add-in or as a standalone add-in that builds on the KNX lib like Zigbee? And if so, how would that work? p.s. sorry for the extreemly long delay in getting back on this, but was completely swamped. |
|
I have rebased the branch to the most current version on main, and I have addressed the issues, and fixed a single bug. This has been running on my Homey since it was created and seems quite stable. Sorry for the very long response time @MerelHudepohl @ttherbrink |
|
I will fix the linting issues |
|
@ttherbrink I have fixed the linting issues and cleaned a little bit of coding styles. |
3 participants
And before going into details on this implementation, I think it is worth to think about a future where all devices might not share the .homeycompose/drivers/pair/select_groupaddresses/index.html
Maybe there is a way to make it dynamic based on the settings object?
From a feature point of view this device is functioning quite well (running it now) but I am unsure about how you see the future of specific devices.
I specifically made this because it is a device that absolutely does not fit into the existing thermostat driver, and it is so specific that I don't think it would make sense to create a generic setpoint shift type thermostat.
What do you think? Because I don't see a way (new to Homey) that we could make a system like Zigbee/BLE/ZWave where other apps could be developed for specific devices? They all have to be in this repository, right?