feat(thermostat): configurable min/max temperature limits#82
Open
sebglon wants to merge 12 commits intoathombv:masterfrom
Open
feat(thermostat): configurable min/max temperature limits#82sebglon wants to merge 12 commits intoathombv:masterfrom
sebglon wants to merge 12 commits intoathombv:masterfrom
Conversation
…ure limit listeners
…ty, and validation Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Expand target_temperature_min/max capability options before calling setCapabilityValue so values outside the built-in 4–35 range are accepted. Also call setCapabilityOptions on target_temperature before setCapabilityValue so the slider validation uses the updated range. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add ga_temperature_min and ga_temperature_max input fields to the thermostat fieldset in the select_groupaddresses pairing screen, and include their values in the device save handler. Add i18n strings for all 13 supported locales. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
min_temperature(default 4°C) andmax_temperature(default 35°C) number fields, allowing users to configure the target temperature slider rangega_temperature_min/ga_temperature_maxKNX group address fields (DPT9.1, read-only) that dynamically override the static limits at runtime when telegrams arrive — KNX values take precedencetarget_temperature_minandtarget_temperature_maxas Homey capabilities, making current limits visible in the device UI and available in flowsMotivation
Fixes #79 — thermostats used for hot water regulation or other non-HVAC use cases need a wider temperature range (e.g. up to 70°C) than the hardcoded 4–35°C default. KNX devices like the OT-box can also send setpoint limits over the bus.
Test Plan
min=4/max=35defaultsmax_temperatureto70→ confirm target temperature slider extends to 70°Ctarget_temperature_minandtarget_temperature_maxappear as capabilities on the device cardga_temperature_maxwith a valid KNX GA → send a DPT9.1 telegram (e.g. 65°C) → confirm slider max updatesga_temperature_maxand changemax_temperaturein settings → confirm static value is applied again🤖 Generated with Claude Code