Skip to content

protected (some) complex variants from left-trimming in normalize#75

Open
selkovjr wants to merge 2 commits into
atks:masterfrom
selkovjr:master
Open

protected (some) complex variants from left-trimming in normalize#75
selkovjr wants to merge 2 commits into
atks:masterfrom
selkovjr:master

Conversation

@selkovjr

Copy link
Copy Markdown

This patch prevents the trimming of complex variants that are already normalized.

Example: trimming CAT -> CG changes it to a form that is hard to analyze: AT -> G. Indeed, some tools, such as freebayes, interpret it incorrectly, while the original combination of a deletion and a SNP presents no problems.

I do not know whether the solution I present here is complete (I suspect not), but it fixes all instances of this type of error I was able to find in my data.

@atks

atks commented Aug 17, 2017

Copy link
Copy Markdown
Owner

@selkovjr - I cannot accept this PR because:

  1. it would contradict the definition of normalization
  2. it is not practical to make exceptions so that a downstream tool will work
  3. It is probably a better idea for you to add an intermediate step between vt normalize and freebayes to manipulate the variants

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants