protected (some) complex variants from left-trimming in normalize#75
Open
selkovjr wants to merge 2 commits into
Open
protected (some) complex variants from left-trimming in normalize#75selkovjr wants to merge 2 commits into
selkovjr wants to merge 2 commits into
Conversation
Owner
|
@selkovjr - I cannot accept this PR because:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch prevents the trimming of complex variants that are already normalized.
Example: trimming
CAT -> CGchanges it to a form that is hard to analyze: AT -> G. Indeed, some tools, such as freebayes, interpret it incorrectly, while the original combination of a deletion and a SNP presents no problems.I do not know whether the solution I present here is complete (I suspect not), but it fixes all instances of this type of error I was able to find in my data.