JPERF-449 fixed compatibility of tests with Ubuntu bionic+ #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbruski
force-pushed
the
JPERF-449-fixed-compatibility-of-tests-with-Ubuntu-bionic+
branch
from
9867efc to
5f07168
Compare
wyrzyk
approved these changes
May 12, 2020
dagguh
reviewed
May 12, 2020
|
|
||
| /** | ||
| * Copy-pasted verbatim from [infrastructure:4.11.0](https://github.com/atlassian/infrastructure/blob/release-4.11.0/src/main/kotlin/com/atlassian/performance/tools/infrastructure/Docker.kt) | ||
| * Copy-pasted verbatim from [infrastructure](https://github.com/atlassian/infrastructure/blob/master/src/main/kotlin/com/atlassian/performance/tools/infrastructure/Docker.kt) |
Contributor
There was a problem hiding this comment.
master is a moving target, but this copy-paste is static.
Author
There was a problem hiding this comment.
Well, the usefulness of this comment is limited to the point where you have to update the Docker copy, I don't think including the version number makes it more useful.
Contributor
There was a problem hiding this comment.
What's the usefulness of imprecision? Whenever master moves forward, this comment is no longer accurate. The bigger the gap from the actual source to master, the more it misleads. Especially if master goes to 5.x.y and e.g. nukes the internal class Docker out of existence. Or, hey infra has added a support for XYZ, but we already are allegedly copied from master, so we don't have to resync it, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.