Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Remove sudo settings from .travis.yml#223

Open
abetomo wants to merge 1 commit into
atom:masterfrom
abetomo:remove_sudo_setting_from_travis
Open

Remove sudo settings from .travis.yml#223
abetomo wants to merge 1 commit into
atom:masterfrom
abetomo:remove_sudo_setting_from_travis

Conversation

@abetomo

@abetomo abetomo commented Apr 25, 2019

Copy link
Copy Markdown

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

'sudo' seems to be unavailable.
Remove sudo settings from .travis.yml

https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration

Alternate Designs

Benefits

Possible Drawbacks

Applicable Issues

@lee-dohm

Copy link
Copy Markdown
Contributor

@smashwilson What do you think here?

@Arcanemagus Arcanemagus left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes this PR itself is making are valid, the CI failures appear to be unrelated to this change so I'll leave merging to @smashwilson if they want to look into those first.

@smashwilson

Copy link
Copy Markdown
Contributor

👍 Yeah, CI is failing because clang-format has breaking changes 🙃 This is an easy merge the next time I have cycles to spend over here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants