String intern is an expensive function, cpu wise. Hence putting it behind flag#210
Open
nikhildp wants to merge 2 commits intoatomikos:masterfrom
Open
String intern is an expensive function, cpu wise. Hence putting it behind flag#210nikhildp wants to merge 2 commits intoatomikos:masterfrom
nikhildp wants to merge 2 commits intoatomikos:masterfrom
Conversation
nikhildp
force-pushed
the
feature/intern-behind-flag
branch
from
30cac53 to
272aee0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For jvms with bigger heapsize, String constant pool also can grow quite huge. This will cause latency in String.intern() call. This is a trade off between heap space vs execution time. For smaller jvms intern call can be still helpful. So putting the same behind flag as a tuning parameter