fix: replace boilerplate code and consolidate common classes#362
Merged
Conversation
4e72926 to
fdb4d95
Compare
gkc
approved these changes
Feb 23, 2026
Contributor
gkc
left a comment
There was a problem hiding this comment.
LGTM thank you @akafredperry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #323
- What I did
- How I did it
NOTES: #363 collates suggestions on further refactoring which should be done separately from this issue (to help review)
- How to verify it
- Description for the changelog
make Keys and Metadata immutable and remove boiler plate code