Skip to content
This repository was archived by the owner on Aug 5, 2025. It is now read-only.

feat: introduce at_signing_algo and hashing_algo in at_auth_request and at_onboarding_request#608

Open
srieteja wants to merge 11 commits intotrunkfrom
at_auth_signing_algo_input
Open

feat: introduce at_signing_algo and hashing_algo in at_auth_request and at_onboarding_request#608
srieteja wants to merge 11 commits intotrunkfrom
at_auth_signing_algo_input

Conversation

@srieteja
Copy link
Copy Markdown
Contributor

@srieteja srieteja commented Jul 11, 2024

Closes atsign-foundation/at_client_sdk#1561
- What I did

  • Introduce SigningAlgoType and HashingAlgoType in at_auth_request and at_onboarding_request
  • Pass signingAlgo and hashingAlgo to at_lookup instance while creation

- How to verify it

  • when using an signing or hashing algorithm other than the default should, indicate the same while sending a from verb command to server

- Description for the changelog

feat: introduce at_signing_algo and hashing_algo in at_auth_request and at_onboarding_request

Comment thread packages/at_auth/lib/src/at_auth_impl.dart Outdated
@srieteja
Copy link
Copy Markdown
Contributor Author

A functional test has been added but skipped for now. It will be unskipped once atsign-foundation/at_server#2045 has been resolved

@gkc
Copy link
Copy Markdown
Contributor

gkc commented Oct 8, 2024

@sitaram-kalluri @srieteja atsign-foundation/at_server#2045 has been resolved - let's unskip the test and get this PR reviewed and merged

srieteja

This comment was marked as resolved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AtSigningAlgo and AtHashingAlgo data set in OnboardingCli not reaching AtAuth

3 participants